etseidl commented on code in PR #10842:
URL: https://github.com/apache/arrow-rs/pull/10842#discussion_r3867054636
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -323,18 +254,8 @@ impl PageIndex {
/// Returns:
/// * `Some(&OffsetIndexMetaData)` - Offset index is available
/// * `None` - Index unavailable (not loaded, row group/column out of
bounds)
- pub fn offset_index(
- &self,
- row_group_idx: usize,
- column_idx: usize,
- ) -> Option<&OffsetIndexMetaData> {
- if let Some(offset_indexes) = self.offset_indexes.as_ref() {
- let rg = offset_indexes.get(row_group_idx)?;
- rg.get(column_idx)?.as_ref()
- } else {
- None
- }
- }
+ fn offset_index(&self, row_group_idx: usize, column_idx: usize)
Review Comment:
I do link to it in the docs for `PageIndexProvider`, but repeating here
isn't a bad idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
