Jefffrey commented on code in PR #10441:
URL: https://github.com/apache/arrow-rs/pull/10441#discussion_r3868104885
##########
arrow-select/src/take.rs:
##########
@@ -766,31 +766,87 @@ fn take_fixed_size_list<IndexType: ArrowPrimitiveType>(
indices: &PrimitiveArray<IndexType>,
length: <UInt32Type as ArrowPrimitiveType>::Native,
) -> Result<FixedSizeListArray, ArrowError> {
- let list_indices = take_value_indices_from_fixed_size_list(values,
indices, length)?;
- let taken = take_impl::<UInt32Type>(values.values().as_ref(),
&list_indices)?;
+ let field = match values.data_type() {
+ DataType::FixedSizeList(field, _) => field.clone(),
+ d => unreachable!("take_fixed_size_list called with
non-fixed-size-list data type {d}"),
+ };
Review Comment:
```suggestion
let field = values.value_field().clone();
```
- thanks to https://github.com/apache/arrow-rs/pull/10661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
