Rich-T-kid commented on code in PR #10820:
URL: https://github.com/apache/arrow-rs/pull/10820#discussion_r3873562226
##########
arrow-select/src/take.rs:
##########
@@ -98,7 +98,7 @@ pub fn take(
check_bounds(values.len(), indices)?;
}
let indices = indices.to_indices();
- take_impl(values, &indices)
+ take_impl::<_, true>(values, &indices)
Review Comment:
Noteworthy that this only creates the `take_impl<true>` branch of this. This
means this PR essentially doesn't do anything, which is intentional.
##########
arrow-select/src/take.rs:
##########
@@ -469,7 +469,7 @@ fn take_bits<I: ArrowPrimitiveType>(
let output_slice = output_buffer.as_slice_mut();
nulls.valid_indices().for_each(|idx| {
// SAFETY: idx is a valid index in indices.nulls() -->
idx<indices.len()
- if values.value(unsafe {
indices.value_unchecked(idx).as_usize() }) {
+ if unsafe {
values.value_unchecked(indices.value_unchecked(idx).as_usize()) } {
Review Comment:
revert this to use value.value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
