wgtmac commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r3870742642
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -335,15 +338,46 @@ class RowGroupSerializer : public
RowGroupWriter::Contents {
// An implementation of ParquetFileWriter::Contents that deals with the Parquet
// file structure, Thrift serialization, and other internal matters
+namespace {
+
+std::shared_ptr<GroupNode> MakeWriterSchema(const GroupNode& input_schema,
Review Comment:
Should we remove this function? The `Open` function below should preserve
the input schema. This provides the flexibility of low-level api to enable
users to mix ieee754 and type_defined order for different floating-point
columns.
Instead, we can move `floating_point_column_order()` to
`ArrowWriterProperties` so we are converting Arrow schema to parquet GroupNode
with expected column order at all once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
