hareshkh commented on code in PR #10670:
URL: https://github.com/apache/arrow-rs/pull/10670#discussion_r3882353402
##########
arrow-json/src/reader/mod.rs:
##########
@@ -745,11 +885,18 @@ impl DecoderContext {
self.ignore_type_conflicts
}
+ /// Returns the optional hook for customizing decoding behavior
+ pub fn decoder_factory(&self) -> Option<&Arc<dyn DecoderFactory>> {
+ self.decoder_factory.as_ref()
+ }
+
/// Create a decoder for a type.
///
- /// This is the standard way to create child decoders from within a decoder
- /// implementation.
- fn make_decoder(
+ /// The standard way to create child decoders from within a decoder, and
how a
+ /// [`DecoderFactory`] delegates to the decoder the reader would otherwise
use.
+ /// The factory is consulted first, so calling this for the same data type
the
Review Comment:
Added `make_builtin_decoder`, please let me know if naming looks off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
