zeroshade commented on code in PR #1223:
URL: https://github.com/apache/arrow-go/pull/1223#discussion_r3883533474
##########
arrow/array/dictionary.go:
##########
@@ -683,13 +683,20 @@ func (b *dictionaryBuilder) AppendEmptyValues(n int) {
valueBuilder := NewBuilder(b.mem, b.dt.ValueType)
defer valueBuilder.Release()
- valueBuilder.AppendEmptyValues(n)
+ valueBuilder.AppendEmptyValue()
values := valueBuilder.NewArray()
defer values.Release()
- if err := b.AppendArray(values); err != nil {
+ idx, _, err := b.memoTable.GetOrInsert(getvalFn(values)(0))
+ if err != nil {
panic(err)
}
+
+ b.idxBuilder.Builder.Reserve(n)
Review Comment:
The repository’s lint hook rewrites this to `b.idxBuilder.Reserve(n)`,
causing the required Lint check to fail because the hook modifies the file.
Please use the promoted method and rerun lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
