zeroshade commented on code in PR #1235:
URL: https://github.com/apache/arrow-go/pull/1235#discussion_r3882159162
##########
parquet/pqarrow/file_reader.go:
##########
@@ -370,6 +385,39 @@ func (fr *FileReader) ReadRowGroups(ctx context.Context,
indices, rowGroups []in
return nil, err
}
+ if !fr.Props.Parallel {
+ columns := make([]arrow.Column, sc.NumFields())
+ defer releaseColumns(columns)
+ defer func() {
+ for _, rdr := range readers {
+ rdr.Release()
+ }
+ }()
+
+ for idx, rdr := range readers {
+ if err := ctx.Err(); err != nil {
+ return nil, err
+ }
+
+ data, err := fr.ReadColumn(rowGroups, rdr)
Review Comment:
`ReadColumn` previously ran inside the worker’s deferred recovery boundary,
which converted decoder panics into `panic while reading: …` errors. Calling it
directly here lets those panics escape from `ReadTable`.
I reproduced this through the public `FileReader` flow with a malformed
extension implementation: the base returns the recovered error, while this head
panics. Please preserve the recovery boundary for synchronous reads—ideally
through a shared guarded helper—and add regression coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
