cakeni commented on code in PR #10635:
URL: https://github.com/apache/arrow-rs/pull/10635#discussion_r3885157425
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -2898,6 +2911,49 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_variant_schema_builder_list() -> Result<()> {
+ let shredding_type = ShreddedSchemaBuilder::default()
+ .with_path("items[0].id", &DataType::Int64)?
+ .with_path("items[42].name", &DataType::Utf8)?
Review Comment:
Agreed, `[0]` is confusing here since it already means the first array
element in `VariantPath`. I’d prefer `[*]` for the shared element schema and
keep numeric indexes unchanged. A separate list API seems harder to compose
with nested paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
