alamb commented on code in PR #10899:
URL: https://github.com/apache/arrow-rs/pull/10899#discussion_r3886755287
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -1342,13 +1342,16 @@ impl ColumnChunkMetaData {
self.column_index_offset
}
- /// Returns the offset for the column index length.
+ /// Returns the length for the column index.
pub fn column_index_length(&self) -> Option<i32> {
self.column_index_length
}
- /// Returns the range for the offset index if any
- pub(crate) fn column_index_range(&self) -> Option<Range<u64>> {
+ /// Returns the range for the column index, if any.
Review Comment:
it make also make sense to explain here this is the byte range in the
original file where the column index is stored (to. distinguish it from the
parsed version / whatever is in memory)
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -1359,13 +1362,16 @@ impl ColumnChunkMetaData {
self.offset_index_offset
}
- /// Returns the offset for the offset index length.
+ /// Returns the length for the offset index.
pub fn offset_index_length(&self) -> Option<i32> {
self.offset_index_length
}
- /// Returns the range for the offset index if any
- pub(crate) fn offset_index_range(&self) -> Option<Range<u64>> {
+ /// Returns the range for the offset index, if any.
Review Comment:
same suggestion here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
