Rich-T-kid commented on code in PR #10911:
URL: https://github.com/apache/arrow-rs/pull/10911#discussion_r3888025220
##########
arrow-arith/src/numeric.rs:
##########
@@ -967,6 +967,59 @@ fn date_op<T: DateOp>(
}
}
+/// Divides `l * 10^mul_pow` by `r` a digit at a time, without forming the
scaled numerator.
+/// Used when scaling `l` would overflow `T::Native`, which it does well
before the quotient
+/// does.
+///
+/// Runs on magnitudes and restores the sign last, so it truncates toward zero
like the
+/// direct path.
Review Comment:
nit:
```suggestion
/// Runs on magnitudes and restores the sign last, so it truncates toward
zero.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
