lidavidm commented on code in PR #1027:
URL: https://github.com/apache/arrow-java/pull/1027#discussion_r3891035632
##########
flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/NettyClientBuilder.java:
##########
@@ -139,7 +139,12 @@ public NettyChannelBuilder build() {
case LocationSchemes.GRPC_INSECURE:
case LocationSchemes.GRPC_TLS:
{
- builder = NettyChannelBuilder.forAddress(location.toSocketAddress());
+ final int port = location.getUri().getPort();
+ if (port < 0 || port > 65535) {
+ throw new IllegalArgumentException(
Review Comment:
Just to confirm, this is the same exception class that gRPC used to throw
for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
