Rich-T-kid commented on code in PR #10919:
URL: https://github.com/apache/arrow-rs/pull/10919#discussion_r3891662919
##########
arrow/benches/zip_kernels.rs:
##########
@@ -268,63 +262,23 @@ fn add_benchmark(c: &mut Criterion) {
},
);
- // Short strings
bench_zip_on_input_generator(
c,
&GenerateBytes::<GenericStringType<i32>> {
- description: "short strings (3..10)".to_string(),
+ description: "strings (3..20)".to_string(),
range_length: 3..10,
_marker: std::marker::PhantomData,
},
);
- // Long strings
- bench_zip_on_input_generator(
- c,
- &GenerateBytes::<GenericStringType<i32>> {
- description: "long strings (100..400)".to_string(),
- range_length: 100..400,
- _marker: std::marker::PhantomData,
- },
- );
-
- // Short Bytes
- bench_zip_on_input_generator(
- c,
- &GenerateBytes::<GenericBinaryType<i32>> {
- description: "short bytes (3..10)".to_string(),
- range_length: 3..10,
- _marker: std::marker::PhantomData,
- },
- );
-
- // Long Bytes
- bench_zip_on_input_generator(
- c,
- &GenerateBytes::<GenericBinaryType<i32>> {
- description: "long bytes (100..400)".to_string(),
- range_length: 100..400,
- _marker: std::marker::PhantomData,
- },
- );
-
bench_zip_on_input_generator(
c,
&GenerateStringView {
- description: "string_views size (3..10)".to_string(),
+ description: "string_views size (3..20)".to_string(),
range: 3..10,
Review Comment:
same here?
##########
arrow/benches/zip_kernels.rs:
##########
@@ -268,63 +262,23 @@ fn add_benchmark(c: &mut Criterion) {
},
);
- // Short strings
bench_zip_on_input_generator(
c,
&GenerateBytes::<GenericStringType<i32>> {
- description: "short strings (3..10)".to_string(),
+ description: "strings (3..20)".to_string(),
range_length: 3..10,
Review Comment:
should we increase the `range_length` to 20 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
