lidavidm commented on a change in pull request #10201:
URL: https://github.com/apache/arrow/pull/10201#discussion_r636040540
##########
File path: cpp/src/jni/dataset/jni_wrapper.cc
##########
@@ -166,6 +156,126 @@ class DisposableScannerAdaptor {
}
};
+/// \brief Simple scan task implementation that is constructed directly
+/// from a record batch iterator (and its corresponding fragment).
+class SimpleIteratorTask : public arrow::dataset::ScanTask {
Review comment:
ScanTask is going away. However, from a quick glance, what we want here
is a Scanner from a RecordBatchIterator. Use the existing
Scanner::FromRecordBatchReader:
https://github.com/apache/arrow/blob/8b0e04961790003abb32ef03e19a4604060e88ec/cpp/src/arrow/dataset/scanner.h#L323-L329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
