ennuite opened a new pull request, #1282:
URL: https://github.com/apache/arrow-java/pull/1282
## Summary
Closes #1271. Deferred from #1027.
- Tightens the port validation in `NettyClientBuilder.build()` from `port <
0` to `port < 1` (port 0 is reserved and invalid for client TCP connections)
- Fixes four builder-based tests that never called `.withPort()`, so the
port field defaulted to 0 unnoticed:
- `ConnectionTest.testGetBasicClientNoAuthShouldOpenConnection`
- `ConnectionTlsTest.testGetNonAuthenticatedEncryptedClientNoAuth`
- `ConnectionTlsRootCertsTest.testGetNonAuthenticatedEncryptedClientNoAuth`
- `ConnectionMutualTlsTest.testGetNonAuthenticatedEncryptedClientNoAuth`
- Converts `testUnencryptedConnectionProvidingInvalidPort` to a
`@ParameterizedTest` covering ports `0`, `-1`, `65536`, and `65537`
## Test plan
- [ ] All existing tests pass
- [ ] `testUnencryptedConnectionProvidingInvalidPort` runs for all four
invalid port values including 0
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
