Copilot commented on code in PR #51103:
URL: https://github.com/apache/arrow/pull/51103#discussion_r3896059797
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -743,11 +743,11 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
# flags for building test executables for use in node
if("${UPPERCASE_BUILD_TYPE}" STREQUAL "RELEASE")
set(CMAKE_EXE_LINKER_FLAGS
- "${ARROW_EMSCRIPTEN_LINKER_FLAGS} -sALLOW_MEMORY_GROWTH -lnodefs.js
-lnoderawfs.js --pre-js ${BUILD_SUPPORT_DIR}/emscripten-test-init.js"
+ "${ARROW_EMSCRIPTEN_LINKER_FLAGS} -sSTACK_SIZE=1048576
-sALLOW_MEMORY_GROWTH -lnodefs.js -lnoderawfs.js --pre-js
${BUILD_SUPPORT_DIR}/emscripten-test-init.js"
Review Comment:
The Emscripten test stack size is a hard-coded value duplicated in both
build-type branches. Defining it once (with a short “1 MiB” note) reduces
duplication and makes it easier to tune if future failures require a different
size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
