zeroshade commented on code in PR #1264: URL: https://github.com/apache/arrow-go/pull/1264#discussion_r3898230963
########## arrow/bitutil/bitmap_ops_neon_arm64.s: ########## @@ -0,0 +1,261 @@ +//go:build !noasm && !appengine +// +build !noasm,!appengine + +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +TEXT ยท_bitmap_aligned_and_neon(SB), $0-32 + MOVD left+0(FP), R0 + MOVD right+8(FP), R1 + MOVD out+16(FP), R2 + MOVD length+24(FP), R3 + +and_loop: + CMP $64, R3 Review Comment: These NEON loops do not preserve the existing behavior for partially overlapping input/output ranges. For example, using `backing[:256]` as input and `backing[1:257]` as output produces different results from `-tags noasm` for all five bitmap operations because each store can overwrite bytes a later block has not loaded. The amd64 SIMD wrappers already detect this case. Please add equivalent overlap detection to the ARM64 wrappers, fall back to the Go implementation, and add shifted-overlap regressions larger than 64 bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
