fallintoplace commented on PR #1256: URL: https://github.com/apache/arrow-go/pull/1256#issuecomment-5484830495
I think there may still be a similar issue with `RLE_DICTIONARY -> BYTE_STREAM_SPLIT`. Possible repro: 1. Decode an FLBA dictionary page with repeated values, e.g. indexes `[0, 0, 1]`. The first two entries in `valueBuf` can point to the same dictionary-backed slice. 2. Reuse the same `valueBuf` for a BYTE_STREAM_SPLIT page with distinct values `[A, B, C]`. 3. BSS writes through the existing slices before `spacedExpandSwap` runs, so writing `B` can overwrite `A` because the first two entries alias. This one shouldn't need nulls. Could we add a `RLE_DICTIONARY -> BYTE_STREAM_SPLIT` regression test too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
