amoeba commented on code in PR #4694: URL: https://github.com/apache/arrow-adbc/pull/4694#discussion_r3896223875
########## c/include/arrow-adbc/adbc.h: ########## @@ -1087,6 +1093,582 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// @} +/// \defgroup adbc-statement-metadata-collection Metadata Collections +/// +/// Fetch (catalog) metadata from the database. On a statement, set +/// ADBC_METADATA_COLLECTION to one of the collection names below, and set any +/// filters via the options defined below. (There are driver/vendor-specific +/// collections and filters as well.) Then call AdbcStatementExecuteQuery or +/// AdbcStatementExecuteSchema. The result is an Arrow dataset with a schema +/// defined by the collection. For example, a client may request a list of +/// tables in the database, or a list of supported data types. +/// +/// All drivers must implement a collection called "meta" (which is aliased to +/// NULL and blank string) that defines the available collections. See +/// ADBC_METADATA_COLLECTION_META. +/// +/// Drivers may also implement AdbcStatementRequestSchema to (1) request +/// different data types and (2) drop fields from the result. Drivers are not Review Comment: Hrm. The current doc comment on AdbcStatementRequestSchema says, > column reordering or changing the number of returned columns > is not a goal of this feature. Could what say here in this PR be confusing given that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
