paultiq commented on code in PR #51028:
URL: https://github.com/apache/arrow/pull/51028#discussion_r3900153161


##########
dev/tasks/macros.jinja:
##########
@@ -26,6 +26,7 @@ on:
 
 env:
   ARCHERY_DEBUG: 1
+  SCCACHE_OIDC_ROLE: {{ '${{ secrets.AWS_ROLE_ARN }}' }}

Review Comment:
   The reasoning was to enable this check: `    if: env.SCCACHE_OIDC_ROLE != '' 
`, since you can't use a secret directly in a GHA `if` statement.
   
   Alternatively, and probably preferably: could use something like 
SCCACHE_ENABLED (or another SCCACHE_* field) as the sentry instead of 
SCCACHE_OIDC_ROLE. 
   
   Perhaps SCCACHE_REGION (existing) or SCCACHE_ENABLED (new)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to