kou commented on code in PR #51117:
URL: https://github.com/apache/arrow/pull/51117#discussion_r3900181351
##########
dev/archery/archery/release/cli.py:
##########
@@ -67,13 +67,14 @@ def release_changelog_add(obj, version):
# just handle the current version
release = Release(version, repo=repo, issue_tracker=issue_tracker)
- if release.is_released:
- raise ValueError('This version has been already released!')
changelog = release.changelog()
changelog_path = pathlib.Path(repo) / 'CHANGELOG.md'
current_content = changelog_path.read_text()
+ if f'# Apache Arrow {version} (' in current_content:
+ raise ValueError(
+ f'CHANGELOG.md already contains the changelog of {version}!')
Review Comment:
We may not need this check.
##########
CHANGELOG.md:
##########
Review Comment:
Copied existing entries from `CHANGELOG.md` in existing tags.
##########
dev/release/post-10-bump-versions.sh:
##########
@@ -70,6 +71,13 @@ if [ ${BUMP_UPDATE_LOCAL_DEFAULT_BRANCH} -gt 0 ]; then
git rebase upstream/${DEFAULT_BRANCH}
fi
+if [ ${BUMP_CHANGELOG} -gt 0 ]; then
+ echo "Updating CHANGELOG.md for ${version}"
+ archery release changelog add ${version}
+ git add "${SOURCE_DIR}/../../CHANGELOG.md"
+ git commit -m "MINOR: [Release] Update CHANGELOG.md for ${version}"
+fi
Review Comment:
@raulcd @amoeba Should we rename `bump-versions` file name? Updating
changelog may not be "bump versions"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
