Jefffrey commented on code in PR #10301:
URL: https://github.com/apache/arrow-rs/pull/10301#discussion_r3902558186
##########
arrow-buffer/src/pool.rs:
##########
@@ -23,9 +23,9 @@
//! is as follows:
//!
//! ```text
-//! (pool tracker) (resizable)
+//! (pool tracker) (resizable)
//! ┌──────────────────┐ fn reserve() ┌─────────────────────────┐
-//! │ trait MemoryPool │─────────────►│ trait MemoryReservation │
+//! │ trait MemoryPool │────────────►│ trait MemoryReservation │
Review Comment:
```suggestion
//! │ trait MemoryPool │─────────────►│ trait MemoryReservation │
```
##########
arrow-buffer/src/pool.rs:
##########
@@ -52,20 +52,20 @@ pub trait MemoryReservation: Debug + Send + Sync {
/// tell if the buffer is shared or not.
///
/// ```text
-/// Array A Array B
+/// Array A Array B
/// ┌────────────┐ ┌────────────┐
/// │ slices... │ │ slices... │
/// │────────────│ │────────────│
/// │ Arc<Bytes> │ │ Arc<Bytes> │ (shared buffer)
-/// └─────▲──────┘ └───────▲────┘
-/// │ │
-/// │ Bytes │
-/// │ ┌─────────────┐ │
-/// │ │ data... │ │
-/// │ │─────────────│ │
-/// └──│ Memory │──┘ (tracked with a memory pool)
-/// │ Reservation │
-/// └─────────────┘
+/// └─────▲─────┘ └───────▲───┘
Review Comment:
```suggestion
/// └─────▲──────┘ └───────▲────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
