klion26 commented on code in PR #10114:
URL: https://github.com/apache/arrow-rs/pull/10114#discussion_r3903661458
##########
arrow-cast/src/display.rs:
##########
@@ -752,7 +756,8 @@ macro_rules! decimal_display {
decimal_display!(Decimal32Type, Decimal64Type, Decimal128Type, Decimal256Type);
-fn write_timestamp(
+/// Writes a timestamp value to the output using the given representation.
+pub fn write_timestamp(
Review Comment:
Changed; I meant to make the logic aligned with arrow-cast, even if we
change the logic in arrow-cast later, but we have a test to cover this, and the
logic is simple; copied to parquet-variant crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
