emilk commented on code in PR #10935: URL: https://github.com/apache/arrow-rs/pull/10935#discussion_r3905115143
########## Cargo.toml: ########## @@ -224,7 +224,6 @@ cast_lossless = "allow" # ~640 violations in ~100 files cast_possible_truncation = "allow" # ~890 violations in ~190 files cast_possible_wrap = "allow" # ~570 violations in ~120 files cast_precision_loss = "allow" # ~130 violations in ~33 files -cast_ptr_alignment = "allow" # ~3 violations in ~3 files Review Comment: It didn't fix anything in the current code no, but it will help protect us against future mis-alignment bugs 🤷 See https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment for more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
