pitrou commented on PR #51000:
URL: https://github.com/apache/arrow/pull/51000#issuecomment-5496280470
@shoemoney Hi, thanks for submitting this. Some high-level comments after
taking a quick look:
1. This is not a MINOR change, can you open a separate issue for the bug?
2. Dictionary values (not only indices) can be null too, does your PR handle
that?
3. A potentially simpler solution is to call `is_null` on the dictionary
values:
a. dict_is_null = is_null(dict_array.dictionary)
b. temp_is_null = take(dict_is_null, dict_array.indices)
c. final_is_null = BitmapOrNot(temp_is_null.values,
temp_is_null.validity_bitmap)
@zanmato1984 Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
