Alb3e3 commented on PR #51027: URL: https://github.com/apache/arrow/pull/51027#issuecomment-5496854400
Thanks, both addressed in 3abb59ae80. - `bridge.cc`: replaced the manual extension-storage unwrap with `data->type->storage_id()`, and switched the two `physical_type->id()` checks to the resulting `physical_type_id`. - Added `ExampleDenseUnionExtension` / `ExampleSparseUnionExtension` to `arrow/testing` (declared in `extension_type.h`, defined in `gtest_util.cc` beside `ExampleUuid` et al.), and the export test now calls those instead of the inline lambdas. On the two cross-implementation notes: agreed that arrow-go and nanoarrow will need the same wrapping guard in their integration consumers for the extension-wrapped union to be exercised there, and that a registration gap could otherwise hide a bug. That is outside this C++/Python change; I have left it for @paleolimbot / @zeroshade as you flagged rather than pull it into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
