nealrichardson commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r636179320
##########
File path: r/R/compute.R
##########
@@ -95,10 +95,14 @@ list_compute_functions <- function(pattern = NULL, ...) {
}
#' @export
-sum.ArrowDatum <- function(..., na.rm = FALSE) scalar_aggregate("sum", ...,
na.rm = na.rm)
+sum.ArrowDatum <- function(..., na.rm = FALSE, na.min_count = 0) {
+ scalar_aggregate("sum", ..., na.rm = na.rm, na.min_count = na.min_count)
+}
#' @export
-mean.ArrowDatum <- function(..., na.rm = FALSE) scalar_aggregate("mean", ...,
na.rm = na.rm)
+mean.ArrowDatum <- function(..., na.rm = FALSE, na.min_count = 0) {
+ scalar_aggregate("mean", ..., na.rm = na.rm, na.min_count = na.min_count)
+}
Review comment:
```suggestion
mean.ArrowDatum <- function(..., na.rm = FALSE) {
scalar_aggregate("mean", ..., na.rm = na.rm)
}
```
##########
File path: r/R/compute.R
##########
@@ -95,10 +95,14 @@ list_compute_functions <- function(pattern = NULL, ...) {
}
#' @export
-sum.ArrowDatum <- function(..., na.rm = FALSE) scalar_aggregate("sum", ...,
na.rm = na.rm)
+sum.ArrowDatum <- function(..., na.rm = FALSE, na.min_count = 0) {
+ scalar_aggregate("sum", ..., na.rm = na.rm, na.min_count = na.min_count)
+}
Review comment:
`na.min_count` will propagate through `...` if anyone passes it (but
they won't).
```suggestion
sum.ArrowDatum <- function(..., na.rm = FALSE) {
scalar_aggregate("sum", ..., na.rm = na.rm)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
