sqd commented on code in PR #10771:
URL: https://github.com/apache/arrow-rs/pull/10771#discussion_r3908509113
##########
arrow-avro/src/reader/record.rs:
##########
@@ -250,11 +250,15 @@ enum Decoder {
/// String data encoded as UTF-8 bytes, but mapped to Arrow's
StringViewArray
StringView(OffsetBufferBuilder<i32>, Vec<u8>),
Array(FieldRef, OffsetBufferBuilder<i32>, Box<Decoder>),
+ /// The trailing `usize` counts the rows appended since the last flush. A
record with no
+ /// fields has no child array to take a length from, so this is the only
length available to
+ /// it; it is maintained for every record to keep the arms uniform.
Record(
Fields,
Vec<Decoder>,
Vec<Option<AvroLiteral>>,
Option<Projector>,
+ usize,
Review Comment:
thanks for the review! The fields are now named.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
