shoemoney commented on PR #51000: URL: https://github.com/apache/arrow/pull/51000#issuecomment-5500679913
Thanks for the look. On (1), agreed — I'll open a separate issue and retitle against it. On (2), no: the current patch only skips null index slots, so a null dictionary *value* referenced by a valid index still gets dereferenced, which is the gap you're pointing at. Your `is_null(dictionary)` → `take` → `BitmapOrNot` approach handles both cases in one pass and is simpler than what I have, so I'd rather switch to it than extend the current loop — I'll do that in this PR unless you or @zanmato1984 would prefer it start fresh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
