sdf-jkl commented on code in PR #10639:
URL: https://github.com/apache/arrow-rs/pull/10639#discussion_r3908884487
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -167,6 +166,11 @@ pub(crate) fn
make_variant_to_shredded_variant_arrow_row_builder<'a>(
)?;
VariantToShreddedVariantRowBuilder::Array(typed_value_builder)
}
+ DataType::FixedSizeList(..) => {
Review Comment:
I think we can merge them.
If we keep it explicit it would require a comment, because someone else
reading the code would come to the same conclusion of dropping it.
Without the historical context a separate arm provides no value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
