Copilot commented on code in PR #51134:
URL: https://github.com/apache/arrow/pull/51134#discussion_r3910906132
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -2471,6 +2471,10 @@ TYPED_TEST(TestStringKernels, TrimUTF8) {
"[\"zȺz矢ba\", null, \"\", \"zȺz\"]", &options);
this->CheckUnary("utf8_rtrim", "[\"azȺz矢ba\", null, \"bab\", \"zȺz\"]",
this->type(),
"[\"azȺz矢\", null, \"\", \"zȺz\"]", &options);
+ this->CheckUnary("utf8_trim",
+ ArrayFromJSON(dictionary(int32(), this->type()),
+ R"(["azȺz矢ba", null, "bab", "zȺz"])"),
+ this->type(), R"(["zȺz矢", null, "", "zȺz"])", &options);
Review Comment:
The new dictionary dispatch path is only exercised for `utf8_trim` and uses
`dictionary(int32(), ...)`, while the PR changes also affect
`utf8_ltrim`/`utf8_rtrim` and the reported issue uses `int64` indices. Adding
coverage for ltrim/rtrim and using `dictionary(int64(), ...)` would better
guard the new DispatchBest logic against regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
