pitrou commented on code in PR #51128:
URL: https://github.com/apache/arrow/pull/51128#discussion_r3912026321
##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -1902,6 +1904,36 @@ TYPED_TEST(TestDeltaBitPackEncoding, BasicRoundTrip) {
}
}
+TYPED_TEST(TestDeltaBitPackEncoding, SingleValueRoundTrip) {
+ ASSERT_NO_FATAL_FAILURE(this->Execute(1, 1));
+}
+
+TYPED_TEST(TestDeltaBitPackEncoding, RejectsMiniblockWidthsLargerThanInput) {
+ using T = typename TypeParam::c_type;
+
+ // Header: 2^25 values per block, 2^20 miniblocks, 2 values, and first value
0,
+ // followed by min delta 0 and no miniblock bit widths.
+ const std::vector<uint8_t> encoded = {0x80, 0x80, 0x80, 0x10, 0x80,
+ 0x80, 0x40, 0x02, 0x00, 0x00};
+ ::arrow::ProxyMemoryPool pool(default_memory_pool());
+ auto decoder = MakeTypedDecoder<TypeParam>(Encoding::DELTA_BINARY_PACKED,
+ this->descr_.get(), &pool);
+ std::vector<T> decoded(2);
+
+ EXPECT_THROW_THAT(
+ [&] {
+ decoder->SetData(2, encoded.data(), static_cast<int>(encoded.size()));
+ decoder->Decode(decoded.data(), static_cast<int>(decoded.size()));
+ },
+ ParquetException,
+ ::testing::Property(
+ &ParquetException::what,
+ ::testing::HasSubstr(
+ "the number of miniblocks per block (1048576) is larger than the
"
+ "number of bytes remaining in the page (1)")));
+ EXPECT_EQ(pool.bytes_allocated(), 0);
Review Comment:
`bytes_allocated` is the number of bytes currently allocated. Do we want to
use `total_bytes_allocated` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
