Rich-T-kid commented on code in PR #10894:
URL: https://github.com/apache/arrow-rs/pull/10894#discussion_r3914461392


##########
arrow-pyarrow/src/lib.rs:
##########
@@ -314,39 +314,51 @@ impl ToPyArrow for Schema {
     }
 }
 
+/// Convert a Python object to [`ArrayData`] without validating the result.
+///
+/// # Safety
+///
+/// The caller must ensure the data produced by the Python object upholds the 
invariants
+/// required by [`ArrayData`]. Prefer [`FromPyArrow::from_pyarrow_bound`] for 
`ArrayData`, which
+/// validates the result before returning it.
+unsafe fn from_pyarrow_bound_unsafe(value: &Bound<PyAny>) -> 
PyResult<ArrayData> {

Review Comment:
   yea in 
https://github.com/apache/arrow-rs/blob/027b45f2a982832c93d159de6718d69d0e8b60e3/arrow-pyarrow/src/lib.rs#L399
   
   its used here
   
https://github.com/apache/arrow-rs/blob/027b45f2a982832c93d159de6718d69d0e8b60e3/arrow-pyarrow/src/lib.rs#L444
   
   
   or were you referring to the new public method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to