alexeigor commented on PR #10958:
URL: https://github.com/apache/arrow-rs/pull/10958#issuecomment-5513651992
Thanks for kicking off the benchmark @Rich-T-kid. That run failed on the
trigger argument rather than on anything in the branch — `arrow-cast` is a
package name, not a bench target, so cargo bailed out before compiling anything:
```console
$ cargo bench --features=arrow,async,test_common,experimental,object_store
--bench arrow-cast
error: no bench target named `arrow-cast` in default-run packages
help: available bench targets:
aggregate_kernels
arithmetic_kernels
...
```
which is what the 6-second `BackoffLimitExceeded` is.
The `arrow-cast` package's own benches are `parse_timestamp`, `parse_time`,
`parse_date`, `parse_decimal` and `format_temporal`, none of which reach
`cast_numeric_arrays`. The bench this PR touches is **`cast_kernels`**, in the
`arrow` package (`arrow/benches/cast_kernels.rs`). The same command with that
target resolves and builds, with the feature list unchanged:
```console
$ cargo bench --features=arrow,async,test_common,experimental,object_store
--bench cast_kernels --no-run
Finished `bench` profile [optimized] target(s) in 21.60s
Executable benches/cast_kernels.rs
```
Could someone re-run it as `run benchmark cast_kernels`? That covers the
`infallible numeric cast i32 to i64` group this PR adds (safe / `safe: false` /
direct `unary`, at 0% and 10% null density), plus the pre-existing cast
benchmarks as a regression check. Numbers from neutral hardware would be much
better than the laptop figures in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
