zeroshade opened a new pull request, #1280: URL: https://github.com/apache/arrow-go/pull/1280
### Rationale for this change Bloom-filter allocator tests rely on GC finalizers/cleanups and immediately assert that all memory was released. GC does not wait for cleanup callbacks, so `TestNewBloomFilter` intermittently reports 64-byte to 2 MiB leaks even though cleanup runs later. ### What changes are included in this PR? - Add an idempotent `Release` method to `BloomFilterBuilder` - Implement explicit release for block-split and adaptive builders - Reuse the release path when adaptive candidates are discarded or finalized - Replace GC-dependent allocator assertions with deterministic release The existing GC cleanup remains as a fallback for callers that do not explicitly release a builder. ### Are these changes tested? - `go test ./parquet/metadata -run 'Test(NewBloomFilter|AdaptiveBlockSplitBloomFilter)' -count=10` - `go test ./parquet/...` - pre-commit hooks ### Are there any user-facing changes? `BloomFilterBuilder` now exposes `Release`, allowing callers to free builder buffers deterministically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
