zeroshade commented on issue #4751:
URL: https://github.com/apache/arrow-adbc/issues/4751#issuecomment-5516508040
After some discussion, I've come to the following result:
We should definitely update the documentation of
adbc-drivers.org/building-drivers/ to state that while `adbc_driver_{name}` is
*recommended* it is by no means *required*. The documentation should point out
that if there is no entrypoint defined in the manifest, the way that we derive
the default entrypoint is as follows:
1. Remove the extensions and any `lib` prefix from the library name
2. Split the name at all hyphens and underscores and then join it together
using PascalCase with an `Init` suffix
3. If the entrypoint doesn't start with `Adbc` we prepend `Adbc` to it
as a result you get the following:
`libadbc_driver_sqlite.so.2.0.0` -> `AdbcDriverSqliteInit`
`adbc_driver_sqlite.dll` -> `AdbcDriverSqliteInit`
`proprietary_driver.dll` -> `AdbcProprietaryDriverInit`
Second: We need to fix the C# driver manager which derives an incorrect
default entrypoint see
https://github.com/apache/arrow-adbc/blob/f1d6412b809784a882ad1c971018e4401c91aecd/csharp/src/Apache.Arrow.Adbc/DriverManager/AdbcDriverManager.cs#L635-L648
It shouldn't be explicitly removing the `adbc_` or `adbc_driver_` prefixes
and shouldn't be injecting `Driver` into the final entrypoint name.
@CurtHagenlocher @davidhcoe would one of you be able to please fix the C#
Driver Manager so that it matches the behavior mentioned above and thus matches
the behavior of all the other driver managers?
Once the C# Driver manager is fixed, and the docs are updated, it shoudn't
be necessary to rename or create aliases during the build for the clickhouse
driver (unless you want to shift to the recommended `adbc_driver_clickhouse`
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
