etseidl commented on code in PR #10963:
URL: https://github.com/apache/arrow-rs/pull/10963#discussion_r3919490143
##########
parquet/src/file/properties.rs:
##########
@@ -788,6 +804,16 @@ impl WriterPropertiesBuilder {
self
}
+ /// Sets whether a column chunk whose data pages are all dictionary
encoded gets a bloom
+ /// filter (defaults to `true` via
[`DEFAULT_BLOOM_FILTER_FOR_DICTIONARY_ENCODED_CHUNKS`]).
+ ///
+ /// The dictionary page of such a chunk already lists every distinct
value, so parquet-java
+ /// skips the bloom filter for it; set this to `false` to write files the
same way.
Review Comment:
I don't think we need the comparison to parquet-java here. I'd instead say
that since the dictionary contains all distinct values, the bloom filter is
redundant and users might wish to save the space by setting this to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
