birschick-bq opened a new pull request, #4752: URL: https://github.com/apache/arrow-adbc/pull/4752
This pull request improves the build process for the FlightSQL driver by making symbol table and debug info inclusion configurable, and by enhancing the robustness of the PowerShell build script. The changes allow for easier debugging and ensure that the build environment is always restored after script execution. **Build configuration improvements:** * [`go/adbc/pkg/Makefile`](diffhunk://#diff-3d66b1b3efe3a6f0931d53153b7487e6bfa13c51de0a8a6e0ee19b161f924e61R40-R48): Added `INCLUDE_SYMBOL_TABLES` and `INCLUDE_DEBUG_INFO` environment variables to control the inclusion of symbol tables and debug information. The `-s` and `-w` linker flags are now conditionally excluded based on these variables, making it easier to generate debug builds when needed. [[1]](diffhunk://#diff-3d66b1b3efe3a6f0931d53153b7487e6bfa13c51de0a8a6e0ee19b161f924e61R40-R48) [[2]](diffhunk://#diff-3d66b1b3efe3a6f0931d53153b7487e6bfa13c51de0a8a6e0ee19b161f924e61L51-R60) **PowerShell script robustness:** * [`csharp/src/Drivers/Interop/FlightSql/Build-FlightSqlDriver.ps1`](diffhunk://#diff-0594c154e1ea558437d54a8e4eaa644b9913f10b495452226afa4f360380066bL38-R51): Updated to set the new environment variables before building, ensuring that builds can include full symbols and debug info. The script now uses a `try/finally` block to always restore the previous working directory, improving reliability and preventing side effects if an error occurs. [[1]](diffhunk://#diff-0594c154e1ea558437d54a8e4eaa644b9913f10b495452226afa4f360380066bL38-R51) [[2]](diffhunk://#diff-0594c154e1ea558437d54a8e4eaa644b9913f10b495452226afa4f360380066bL60-R70) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
