Jefffrey commented on code in PR #10960:
URL: https://github.com/apache/arrow-rs/pull/10960#discussion_r3924009690
##########
arrow-json/src/lib.rs:
##########
@@ -289,7 +289,7 @@ mod tests {
assert!(str::from_utf8(not_utf8).is_err());
let values: &[Option<&[u8]>] = &[
- Some(b"Ned Flanders" as &[u8]),
+ Some(b"Bob Thompson" as &[u8]),
Review Comment:
rest in peace ned
##########
.github/workflows/dev.yml:
##########
@@ -57,3 +57,19 @@ jobs:
# if you encounter error, run the command below and commit the
changes
npx [email protected] --write
{arrow,arrow-flight,dev,arrow-integration-testing,parquet}/**/*.md README.md
CODE_OF_CONDUCT.md CONTRIBUTING.md
git diff --exit-code
+ typos:
+ name: Spell Check with Typos
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 #
v7.0.1
+ with:
+ persist-credentials: false
+ # Version fixed on purpose. It uses heuristics to detect typos, so
upgrading
+ # it may cause checks to fail more often.
+ # We can upgrade it manually once a while.
Review Comment:
put this note above the `with:` otherwise it can suggest its talking about
taiki instead of the typos version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
