Cintu07 commented on issue #10973:
URL: https://github.com/apache/arrow-rs/issues/10973#issuecomment-5537994247

   happy to take this one too.
   
   one thing i want to check before i start. since collect_bool returns Self 
and not a Result, there's no way to report a bad len back to the caller.
   
   i see two ways to handle it:
   
   1. cap the initial reservation, so a bogus len fails during the real work 
instead of aborting on the reservation. this keeps the signature as it is.
   2. add a try_collect_bool that returns Result and leave the existing one 
untouched.
   
   which would you prefer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to