zeroshade commented on code in PR #1285: URL: https://github.com/apache/arrow-go/pull/1285#discussion_r3935662816
########## arrow/compute/registry.go: ########## @@ -14,7 +14,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -//go:build go1.22 +//go:build go1.23 Review Comment: hmm, originally we had the tag to maintain build compatibility with older Go versions for the rest of the module by excluding the compute package from a `go build ./...` command if you weren't using an up to date Go version because we introduced the generics from go 1.18 At this point, I think we can actually get rid of the build tags since I doubt anyone is building this with Go versions earlier than 1.23, we can do that as a follow-up later on rather than as part of this release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
