Jefffrey commented on code in PR #10904:
URL: https://github.com/apache/arrow-rs/pull/10904#discussion_r3939100962
##########
arrow-flight/src/sql/server.rs:
##########
@@ -570,7 +570,11 @@ pub trait FlightSqlService: Sync + Send + Sized + 'static {
}
/// Register a new SqlInfo result, making it available when calling
GetSqlInfo.
- async fn register_sql_info(&self, id: i32, result: &SqlInfo);
+ #[deprecated(
+ since = "59.4.0",
+ note = "takes no value to register and has no effect. Use
`SqlInfoDataBuilder::append` instead"
Review Comment:
```suggestion
note = "Not used in request handling and doesn't accept a value to
register. Use `SqlInfoDataBuilder::append` instead"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
