SHIVANSH-ux-ys commented on PR #51133: URL: https://github.com/apache/arrow/pull/51133#issuecomment-5548692565
Thanks for the thorough review @ennuite! Addressed both items from your review: 1. **Server-side Optionality**: Updated `ActionCreatePreparedStatementResult::is_update` in `server.h` to `std::optional<bool> is_update = std::nullopt;` so servers are allowed to leave the field unset, and `PackActionResult` in `server.cc` only populates the field when present. 2. **Backwards Compatibility Test**: Added unit test `TestCommandPreparedStatementUnsetIsUpdate` in `server_test.cc` verifying that an unset `is_update` field is omitted from the serialized result and evaluates to `std::nullopt` on the client. Ready for re-review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
