Cintu07 commented on issue #10983: URL: https://github.com/apache/arrow-rs/issues/10983#issuecomment-5549121730
saturating works. one thing i hit while looking at it. byte_substring does pair[0] + start at substring.rs:360 and length + new_start at 365, both plain adds. saturate start to i32::MAX and 360 overflows for any element whose start offset is nonzero, so those two need saturating_add or the clamp just moves the wrap one line down. 362 is fine, a negative start only brings pair[1] down. and fair, they're different. #10981 could not build the output type at all, this one builds it fine and indexes wrong. i'll send the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
