yongster commented on PR #10991: URL: https://github.com/apache/arrow-rs/pull/10991#issuecomment-5549710269
@Jefffrey on the relationship with #10994: This PR's `nullif` path for RunEndEncoded and Union delegates to `take` with null indices. That only produces correct logical nulls if `take` itself: - prefers a nullable Union child for a null index - errors when a REE `values` field is non-nullable - errors when a Sparse Union has non-nullable fields Those `take` fixes live in #10994. The small `take.rs` diff here is a subset of that PR, included so this branch still works against current `main`. I'd like to wait for #10994 to land, then rebase this PR so it only contains the `nullif.rs` changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
