thisisnic opened a new pull request, #51166:
URL: https://github.com/apache/arrow/pull/51166

   ### Rationale for this change
   
   `timestamp_parsers` works, but the docs didn't say that supplying parsers 
replaces the default ISO-8601 parser, or that a non-matching parser silently 
falls through to a string column during type inference. Passing 
`convert_options` alongside `timestamp_parsers` also silently discarded the 
latter.
   
   ### What changes are included in this PR?
   
   Rewrites the `timestamp_parsers` documentation and adds an example showing 
how to keep ISO-8601 as a fallback. Adds a warning when `timestamp_parsers` is 
ignored because `convert_options` was supplied, in both the reader and dataset 
paths. Unskips the dataset test for this option.
   
   ### Are these changes tested?
   
   Yes, new tests for the inference path, the ISO-8601 fallback, and the 
warning.
   
   ### Are there any user-facing changes?
   
   Yes, a new warning when `timestamp_parsers` is passed together with 
`convert_options`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to