AntoinePrv commented on code in PR #51122: URL: https://github.com/apache/arrow/pull/51122#discussion_r3948619147
########## cpp/src/arrow/c/dlpack.h: ########## @@ -105,4 +108,32 @@ Result<DLDevice> ExportDevice(const std::shared_ptr<Array>& arr); ARROW_EXPORT Result<DLDevice> ExportDevice(const std::shared_ptr<Tensor>& t); +/// \brief Import a DLPack tensor as an Arrow Array. +/// +/// Same restrictions on data types as `ExportArrayVersioned`, only row-major +/// tensors are supported. Takes ownership of the `DLManagedTensorVersioned` in +/// an error-safe fashion. +/// +/// \param[in] raw DLPack tensor +/// \param[in] copy Whether to copy the data instead of sharing it with the DLPack +/// producer. +/// \return An Arrow Array +ARROW_EXPORT +Result<std::shared_ptr<Array>> ImportArrayVersioned(DLManagedTensorVersioned* raw, Review Comment: Mostly to match the producer side `ExportArrayVersioned`, I feel it easier to match the importing and exporting functions that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
