Copilot commented on code in PR #50195: URL: https://github.com/apache/arrow/pull/50195#discussion_r3957140772
########## cpp/src/arrow/arrow-s3.pc.in: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +prefix=@CMAKE_INSTALL_PREFIX@ +includedir=@ARROW_PKG_CONFIG_INCLUDEDIR@ +libdir=@ARROW_PKG_CONFIG_LIBDIR@ + +Name: Apache Arrow S3 +Description: Apache Arrow's S3 filesystem implementation. +Version: @ARROW_VERSION@ +Requires: arrow +Libs: -L${libdir} -larrow_s3 +Cflags:@ARROW_S3_PC_CFLAGS@ +Cflags.private:@ARROW_S3_PC_CFLAGS_PRIVATE@ Review Comment: The new `arrow-s3.pc` doesn’t expose the AWS SDK link requirements for static linking (there’s no `Libs.private` / `Requires.private`), so `pkg-config --static arrow-s3` will likely omit required AWS SDK (and related) link flags. Related: the build currently appends AWS SDK libs to `arrow.pc`’s `Libs.private` when `ARROW_S3` is enabled (see `cpp/cmake_modules/ThirdpartyToolchain.cmake:4255-4269`), which means consumers linking only Arrow core via pkg-config may still get AWS SDK link flags even though S3 moved to `libarrow_s3`. Consider moving the AWS SDK/static dependency exposure from `arrow.pc` to `arrow-s3.pc` so Arrow core no longer advertises AWS SDK dependencies, and so `arrow-s3.pc` is sufficient for static linking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
