pitrou commented on code in PR #51239:
URL: https://github.com/apache/arrow/pull/51239#discussion_r3960048117
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -68,14 +68,16 @@ parquet::ReaderProperties MakeReaderProperties(
const ParquetFileFormat& format, ParquetFragmentScanOptions*
parquet_scan_options,
const std::string& path = "", std::shared_ptr<fs::FileSystem> filesystem =
nullptr,
MemoryPool* pool = default_memory_pool()) {
- // Can't mutate pool after construction
+ // FIXME: Can't mutate pool after ReaderProperties construction.
parquet::ReaderProperties properties(pool);
if (parquet_scan_options->reader_properties->is_buffered_stream_enabled()) {
properties.enable_buffered_stream();
} else {
properties.disable_buffered_stream();
}
properties.set_buffer_size(parquet_scan_options->reader_properties->buffer_size());
+ properties.set_footer_read_size(
+ parquet_scan_options->reader_properties->footer_read_size());
Review Comment:
This is a drive-by fix for an unrelated buglet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
