singhpratech commented on issue #1296: URL: https://github.com/apache/arrow-go/issues/1296#issuecomment-5589722480
Thank you. The doc sentence is #1303. On the kernels: I would like to take sum, min_max, count, mean, any and all over the numeric and boolean types as a first PR, and hash_sum / hash_count as a second. Reading the package, there is no aggregate kernel type in `exec` yet (only `NonAggKernel` for scalar and vector), no `ScalarAggregateFunction`, and no executor path for a consume/merge/ finalize kernel, so the first PR would have to add those alongside the kernels, following the C++ `ScalarAggregateKernel` shape (Init, Consume, Merge, Finalize) and the C++ semantics for nulls, `skip_nulls` and `min_count`. Before writing that, I will put a short design note on this issue for your sign-off on the kernel interface, so the shape is one you want to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
