zeroshade opened a new pull request, #1301:
URL: https://github.com/apache/arrow-go/pull/1301
### Rationale for this change
#1275 added `-p=1` for Darwin to keep the 7 GB macOS ARM64 runners from
OOM-killing `parquet/file`. That works, but it serializes *every* parquet
package, across both the `assert` and `assert,noasm` passes, under `-race`.
The cost is about 4.5 minutes per macOS job, which ate the entire headroom
against the `timeout-minutes: 20` cap on the `macos` job.
Job durations on `main`, 631 samples over Aug 6 – Sep 8, split at the #1275
merge on Sep 3:
| macOS ARM64 job | before avg | after avg | after max | cap |
| --- | --- | --- | --- | --- |
| Go 1.25 | 11.6m | 16.4m | 20.1m | 20 |
| Go 1.26 | 11.5m | 16.0m | 20.4m | 20 |
| Go 1.25 - CGO | 17.9m | 19.7m | 24.1m | 25 |
| Go 1.26 - CGO | 14.5m | 18.5m | 24.8m | 25 |
Linux is flat across the same window (AMD64 Debian −0.1/+0.2, ARM64 Debian
−0.1/+0.4), which isolates the change to the Darwin-only branch rather than
new tests or runner drift.
Three macOS jobs on `main` have since been killed at the 20-minute mark
(20.1m, 20.4m, 20.4m), and the CGO jobs at 24.8m are one bad run from the
same fate.
### What changes are included in this PR?
Only `parquet/file` holds the large-value regression tests that exhaust the
runner, so give that one package its own `go test` invocation on Darwin and
let the other 17 parquet packages keep their default parallelism. The memory
fix from #1275 is preserved — `parquet/file` still never shares a runner with
another parquet package — without paying for it across the whole tree.
Non-Darwin behaviour is byte-identical to before: two invocations over
`./...`, no `-p` flag.
### Are these changes tested?
- `bash -n ci/scripts/test.sh`
- `shellcheck ci/scripts/test.sh` — clean
- `shfmt -d ci/scripts/test.sh` — clean
- Dry-ran the package partition against this tree: on Darwin it yields 1
serial package (`.../parquet/file`) and 17 parallel, with no leakage of
`file` into the parallel set; on non-Darwin it yields exactly `./...`.
- `go test -tags assert -run XXX ./...` and `go test -tags assert,noasm -run
XXX ./...` in `parquet/` both compile clean, confirming the invocation
form.
The real check is the macOS timings on this PR's own CI run.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
